Open
Conversation
📦 Build Artifacts Ready
|
PeterPetrik
reviewed
Jan 22, 2026
app/CMakeLists.txt
Outdated
| # Other | ||
| # ######################################################################################## | ||
|
|
||
| if (ANDROID AND SquishQtBuiltinHook_FOUND) |
Contributor
There was a problem hiding this comment.
Should be separate file FindSquish.cmake - also it should use find_package and other standart cmake behavior how to Find new libearies and include files
Contributor
Author
|
@PeterPetrik thanks for the insight. For now we are not sure if we want to proceed with Squish and we are still trialing it. |
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
Contributor
Author
|
Ideally we should add a check to verify there are not |
Contributor
Author
|
@PeterPetrik do you want to have a second look? |
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Squish support for these platforms:
Windows should be working out of the box but it would be nice to test it out