Add photo card component and update photo component#4317
Add photo card component and update photo component#4317gabriel-bolbotina wants to merge 10 commits intomasterfrom
Conversation
Added page with photo card component Modified form gallery editor
Added larger cards for gallery page
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
I would keep the state as it is, blured area size flexible and padding, text size fixed... the differences will be probably minimal and the text will fill out the spare space if necessary |
Added size property Modified text padding to adapt to the size Added photo card in gallery that adapts to the width
📦 Build Artifacts Ready
|
…PhotoCard components
gabriel-bolbotina
changed the title
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Plus the comments about components I wrote to you.
It would be nice for our reference to note down in MMPhoto (probably) what made the mask work.
There was a problem hiding this comment.
Is there a reason why we copied the whole file into gallery and didn't reuse MMFormPhotoViewer from the app (which was specifically made for this use case) ?
There was a problem hiding this comment.
Because the original MMFormViewer has the photoSketchingLoader and other dependencies were required for this to work. I think we can park the topic of testing the photo sketching in the gallery app, and just keep it a visual tool
There was a problem hiding this comment.
yeah we don't want to test that, can we just pass null there and make it work?
There was a problem hiding this comment.
I tried it, but it fails for the MMInput that is imported by MMFormPhotoViewer with this message "module "MMInput" is not installed". I added it to the gallery's CMakeLists. If you have any suggestions to install it or a workaround, let me know
There was a problem hiding this comment.
Okay yeah that won't work, we will probably need to rip apart the photosketchingcontroller from viewer first
There was a problem hiding this comment.
Let's keep that for future us :)
Added review findings
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
tomasMizera
left a comment
tomasMizera
left a comment
There was a problem hiding this comment.
Looks good 👍🏻 Thanks
3 participants
I created a new component called 'Photo card' which will be used instead of MMPhoto in the Form Gallery editor for features that have multiple photos.
This component has the following configurable properties:
falseTo implement the blur using MultiEffects, I have modified the MMPhoto component by changing the round edged mask to use MultiEffects.
Here are some visuals:
ScreenRecording_02-23-2026.14-05-08_1.mov
Also, I tested that MMPhoto behaves as before:
https://github.com/user-attachments/assets/bec5747e-c64c-475f-98e4-001456675e70
And the gallery photo page:
And the current default state of the app:
latest-visible-set-off.MP4