Skip to content

Fix position bugs#4360

Merged
Withalion merged 7 commits intomasterfrom
fix/position-panel
Mar 2, 2026
Merged

Fix position bugs#4360
Withalion merged 7 commits intomasterfrom
fix/position-panel

Conversation

@Withalion
Copy link
Contributor

@Withalion Withalion commented Mar 2, 2026

Fixes these minor bugs:

  • Fixes elevation available outside local geoid models.
  • Adds geoid model info button for internal providers
  • Fixes translation for geoid model info bubble

@Withalion Withalion added this to the 2026.1.1 milestone Mar 2, 2026
@Withalion Withalion self-assigned this Mar 2, 2026
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that it would be good to show the info icon (which geoid is used) all the time. I think it will now be quite random for users to tell when the icon is visible and when not.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Pull Request Test Coverage Report for Build 22582649795

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 89 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 59.767%

Files with Coverage Reduction New Missed Lines %
mm/core/merginuserauth.cpp 9 68.24%
mm/app/position/positiontransformer.cpp 11 84.96%
mm/core/merginapi.cpp 13 75.07%
mm/app/position/positionkit.cpp 56 67.7%
Totals Coverage Status
Change from base Build 22568885959: -0.1%
Covered Lines: 8769
Relevant Lines: 14672

💛 - Coveralls

@Withalion
Copy link
Contributor Author

We can show the icon all the time, but sometimes we have no clue what model is used to calculate the final value. So, do we want to show something like "Orthometric height, using unknown geoid model"?

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 64391 dmg Expires: 31/05/2026 #6439
linux Build 📬 Mergin Maps 64501 x86_64 Expires: 31/05/2026 #6450
win64 Build 📬 Mergin Maps 56341 win64 Expires: 31/05/2026 #5634
Android Build 📭 Build not yet complete or failed.
iOS Build 📬 Build number: 26.03.869011 #8690

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 64431 dmg Expires: 31/05/2026 #6443
linux Build 📭 Build not yet complete or failed.
win64 Build 📬 Mergin Maps 56381 win64 Expires: 31/05/2026 #5638
Android Build 📬 Mergin Maps 775351 APK [arm64-v8a] Expires: 31/05/2026 #7753
Android Build 📬 Mergin Maps 775311 APK [armeabi-v7a] Expires: 31/05/2026 #7753
iOS Build 📬 Build number: 26.03.869411 #8694

@Withalion Withalion merged commit 59b4851 into master Mar 2, 2026
11 of 12 checks passed
@Withalion Withalion deleted the fix/position-panel branch March 2, 2026 17:23
@Withalion Withalion added test - failure QA team rejected the item and removed test - failure QA team rejected the item labels Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants