Conversation
wonder-sk
reviewed
Oct 12, 2023
Contributor
wonder-sk
left a comment
There was a problem hiding this comment.
- "create" command in CLI should also migrate to the new create_project() API calls
Contributor
Author
|
@wonder-sk This should be ready with all the changes suggested above. The only thing I am slightly unsure is in |
Contributor
|
@JanCaha yeah let's delete that part of the code in CLI... |
wonder-sk
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180
Issue deprecation warnings for
mc.create_project()andmc.clone_project(()ifnamespaceparameter is specified. Still supports the old syntax for backwards compatability.mergin clonewill also print statements ifCLONED_PROJECT_NAMESPACEparameter is used or ifCLONED_PROJECT_NAMEis not a full path that includes workspace name.