Conversation
wonder-sk
reviewed
Oct 12, 2023
Contributor
wonder-sk
left a comment
wonder-sk
left a comment
There was a problem hiding this comment.
In list_projects(), there's the filter_str which will presumably be still showing (all public).
Also the help for --flag option needs updating - it says no flag means returns all public projects...
Looking at the --flag option, I think we should remove it, it just does not make much sense anymore (projects are simply a part of workspace, and it does not matter if it was "created" by the user or "shared" with the user)
wonder-sk
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172
Makes namespace argument of
mergin list-projectswhich should avoid listing way to much projects and thus hanging the tool.