Conversation
Pull Request Test Coverage Report for Build 9345009734Details
💛 - Coveralls |
Updates: - added mc to PullJob class and apply_changes method - added scripts for backup of tests performed for editor
wonder-sk
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! 👏
(commented only minor stuff)
mergin/client_pull.py
Outdated
|
|
||
| try: | ||
| conflicts = job.mp.apply_pull_changes(job.pull_changes, job.temp_dir, job.user_name) | ||
| conflicts = job.apply_changes() |
There was a problem hiding this comment.
I would prefer to keep the direct call to job.mp.apply_pull_changes() instead of introducing a new method in PullJob (it is meant just as a structure to keep everything that is needed for a pull)
probably not, it did not seem to be an issue even with projects with heavy use - and when sending logs to developers, we limit upload size (0.5 mb max if I recall correctly)
what's in the PR looks correct to me, the issue description was not complete... |
Resolves #MerginMaps/qgis-plugin
Details
Added ➕
Refactor 🔨
❓
editor.py