Fix pull error (failing update of basefile)#79
Merged
Conversation
The client used version items from "history" from project info in the order as the server returns them... which is likely sorted, but using lexical sorting, so in some cases it would fail - e.g. when updating from v4 to v11 the order of diffs was v10, v11, v5, v6, v7, v8, v9. This makes sure that the versions are always correctly ordered. Fixes MerginMaps/qgis-plugin#219
Diagnostic logs did not have the key error messages included when an error happened during pull - the error was only shown to the user.
varmar05
approved these changes
Apr 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MerginMaps/qgis-plugin#219
Improves logging during pull.