Better dialog error when trying to create a project with an already existing name and the projects limit hit error.#601
Merged
ValentinBuira merged 16 commits intomasterfrom Sep 25, 2024
Conversation
tomasMizera
reviewed
Jul 9, 2024
Contributor
Author
|
For reviewer, I think it works fine by now but as we handle more and more case we will have a lot of duplicate code because the same error can happen in mutiple place : for exemple StorageLimitHit happen both in I advice to make a more general framework to handle error dialog in the futur |
tomasMizera
reviewed
Jul 19, 2024
tomasMizera
reviewed
Jul 29, 2024
tomasMizera
approved these changes
Sep 11, 2024
Contributor
tomasMizera
left a comment
There was a problem hiding this comment.
Just some AI suggestions for the texts, otherwise it looks good 👍🏻
|
Testing all cases, looking good :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improve the dialog error given to user when trying to create a project and sync project. Instead of giving a dump of the server error we display only the part that matter to the users
So far we handle
This PR also relies on another PR in the mergin python api client (see : MerginMaps/python-api-client/pull/209 )
resolve #599
resolve #561
Before:


After:
