Conversation
Contributor
|
In general, this looks great! Together with @alex-cit, we found an edge case that might need handling. We expected it to be enough to find the grid file of the first transformation. However, when setting up Slovak Baltic heights, the same grid is used for SK and CZ - it's the transformation that defines which one we need. Because of that, we should check the defined project transformations and detect whether any grid is needed. Happy to chat about this on a call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #854
PROJ definitions is kind of a wild jungle without unified standards, so apart of standard QGIS API, regex fallbacks must be applied.
Could be closed #841
TODO:
Didn't find the transformation that needs more grids to be downloaded but not a big deal probably (it's ready).
Disabled vCRS
Warning message for missing grid
Alternatively, failed to find a grid
Download in (background) process
Download success
Validation warning with autofix
