Merge web and gateway images; split up server and celery; enable docker to be run as non-root#234
Conversation
…er to be run as non-root
domfre
changed the title
There was a problem hiding this comment.
Hi. Thanks for PR :) 🥇
- Celery split is ok in docker-compose
- We can move other changes to development docker-compose instead of official docker compose for deployment.
- we want to stay in gateway instead of have one nginx proxy merged with frontend image.
| - db | ||
| networks: | ||
| - merginmaps | ||
| proxy: |
There was a problem hiding this comment.
for production is more reasonable to have gateway. Frontend is just one container in stack ...
There was a problem hiding this comment.
@MarcelGeo I actually disagree on this point, could we discuss it a bit (here or in a meet)? Having 2 nginx servers, one for routing and one for statically serving the webapp actually uses more ram (you need 2 containers), degrades (minimally) the services as an additional request is sent and processed by the second nginx, and makes the deployment on k8s more cumbersome.
There was a problem hiding this comment.
I think it depends on deployment type, I know there are some users already using host nginx as both, proxy and for TLS termination. Also there are users using dockerized proxy as stated in current docker-compose example, so I am bit worried about such changes for inexperienced users.
I agree it could be merged and you guys can certainly do that for your k8s deployments but I would prefer here in public repo to keep is as is even if not optimal. We can instead maybe provide some optimization hints instead?
There was a problem hiding this comment.
I agree with @varmar05 ... It should be useful to have volume for web-app (a.k.a dashboard) nginx config and upgrade It in custom deployment.
domfre
force-pushed
the
GEO-7519-Merginmaps-Helm-Chart-Clean
branch
from
3656289 to
8f05b18
Compare
domfre
force-pushed
the
GEO-7519-Merginmaps-Helm-Chart-Clean
branch
from
9801306 to
50a6045
Compare
danduk82
left a comment
danduk82
left a comment
There was a problem hiding this comment.
@domfre this looks fine from my side. @MarcelGeo this should implement your requested changes, could you review it again please?
Thanks @danduk82 and @domfre ... Let me wait for @varmar05 to review nginx web and gateway ... rest of your changes looks brilliant. |
There's one unresolved discussion about nginx gateway... could we improve It? |
5 participants
Merge web and gateway images; split up server and celery; enable docker to be run as non-root