Set correct Content-Type for responses with custom error#264
Merged
Set correct Content-Type for responses with custom error#264
Conversation
varmar05
reviewed
Aug 14, 2024
varmar05
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2459
Error handling in py-client was done here: MerginMaps/python-api-client#209
Problem:
The 'incorrect'
Content-Typeis when response is not created withabortcommand. This happens when we want some custom attributes in error response.Solution:
Add desirable
Content-Typewith after_request decorator to all custom error responses.Alternative solution could be to set
problem+jsonforContent-Typewhen returning the request in the method.