Use dedicated working directory for Geodiff actions#278
Merged
Conversation
MarcelGeo
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces dedicated working directory for geodiff actions. Necessary files are first copied from live directory and the result of the action is copied back where expected. All temporary files are cleaned afterwards. If copy fails, there is a fallback option to perform the action in current project directory.
The idea behind it is to have a possibility to use dedicated local volumes (with fast disks) for the manipulation with .gpkg files. There should be significant performance improvement comparing to live projects directory often being NFS.
Separation of working directory for files manipulation and storage for live files also opens a way to introduce different storage backend in the future (e.g. S3).
Note: There is no default clean up job for mounted volumes - this should be handled on deployment level.