Add handling for os.renames on different filesystems to avoid OSError#298
Merged
Add handling for os.renames on different filesystems to avoid OSError#298
Conversation
Collaborator
Author
MarcelGeo
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case GEODIFF _WORKING_DIR, LOCAL_PROJECTS_DIR and TEMP_DIR are not on the same filesystem we need to fallback to other renaming convention - use the same FS and only add a marker
delete-me.Normally this should not happen, but for certain deployments on k8s it may be beneficial to have various volumes of different types mounted. In that case a custom clean up job is necessary - this needs to be DOCUMENTED properly!