Roles refactoring: Add new project_member table, update getter/setter…#319
Merged
MarcelGeo merged 5 commits intodevelop-roles-refactorfrom Nov 18, 2024
Merged
Conversation
… for project role
…es-refactor-db-migration
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mostlyAtNight
left a comment
mostlyAtNight
left a comment
There was a problem hiding this comment.
Hi guys, I've reviewed the migration script thoroughly but have not looked at any other part of the MR.
Some other thoughts:
- we should ensure an upgrade/downgrade cycle results in exactly the same states for the tables affected
- do we need to grant any permissions on new tables, or these will be taken care of automaticlaly with default schema permissions?
server/migrations/community/d02961c7416c_add_project_member_table.py
Outdated
Show resolved
Hide resolved
server/migrations/community/d02961c7416c_add_project_member_table.py
Outdated
Show resolved
Hide resolved
server/migrations/community/d02961c7416c_add_project_member_table.py
Outdated
Show resolved
Hide resolved
server/migrations/community/d02961c7416c_add_project_member_table.py
Outdated
Show resolved
Hide resolved
MarcelGeo
commented
Nov 13, 2024
Collaborator
Author
MarcelGeo
left a comment
MarcelGeo
left a comment
There was a problem hiding this comment.
Downgrade, upgrade working for my local data. I also checked if everything is ok with data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/MerginMaps/server-private/issues/2586