Roles refactor: New public API with reworked project roles#337
Merged
MarcelGeo merged 6 commits intodevelop-roles-refactorfrom Dec 10, 2024
Merged
Roles refactor: New public API with reworked project roles#337MarcelGeo merged 6 commits intodevelop-roles-refactorfrom
MarcelGeo merged 6 commits intodevelop-roles-refactorfrom
Conversation
Pull Request Test Coverage Report for Build 12238117740Details
💛 - Coveralls |
MarcelGeo
reviewed
Dec 4, 2024
Collaborator
MarcelGeo
left a comment
There was a problem hiding this comment.
Looks good. Just minor suggestions and one question:
- do we want to use ProjectPermissions.Upload and other methods from project permissions class? I think we could rewrite it or remove.
Collaborator
Author
I did not touch this one, as it is widely used. If we want further refactoring then I'd probably vote for removing it completely. So far it is hanging there if we one day decide to introduce permissions besides roles. |
varmar05
commented
Dec 9, 2024
harminius
approved these changes
Dec 9, 2024
Contributor
harminius
left a comment
There was a problem hiding this comment.
Just curious why we split that project access PUT.
MarcelGeo
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new public
/v2endpoints for project members CRUD and new endpoint for registration of users.Also small refactoring was done (e.g. moving workspace role definition from EE).