Skip to content

Name validations enhancements#366

Merged
MarcelGeo merged 3 commits intodevelopfrom
gh#2740-name-validations
Jan 28, 2025
Merged

Name validations enhancements#366
MarcelGeo merged 3 commits intodevelopfrom
gh#2740-name-validations

Conversation

@MarcelGeo
Copy link
Collaborator

@MarcelGeo MarcelGeo commented Jan 28, 2025

Fixes https://github.com/MerginMaps/server-private/issues/2740

Updated 🔨

  • use pathvalidate lib for filenames like names (project, workspace, username)
  • new error messages for validation (split to separated strings)

Removed 💥 :

  • validation of workspace name which caused bugy validation of underscore in names
  • one regexp for validation

- use pathvalidate lib for filenmaes like names
(project, workspace)
- new error messages for validation
Removed: one regexp for validation
@MarcelGeo MarcelGeo requested a review from varmar05 January 28, 2025 09:18
@MarcelGeo MarcelGeo requested a review from varmar05 January 28, 2025 11:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13009382106

Details

  • 51 of 51 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 93.217%

Totals Coverage Status
Change from base Build 12950402965: 0.04%
Covered Lines: 6693
Relevant Lines: 7180

💛 - Coveralls

@MarcelGeo MarcelGeo merged commit 60f5f75 into develop Jan 28, 2025
4 checks passed
@MarcelGeo MarcelGeo deleted the gh#2740-name-validations branch January 28, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants