Skip to content

Adjust length of username to some sensible length#383

Merged
MarcelGeo merged 3 commits intodevelopfrom
fix_username_validation
Feb 26, 2025
Merged

Adjust length of username to some sensible length#383
MarcelGeo merged 3 commits intodevelopfrom
fix_username_validation

Conversation

@MarcelGeo
Copy link
Collaborator

No description provided.

Copy link
Contributor

@harminius harminius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The length requirement looks fine.

We also have reserved name validation. Not sure with the generic error but ok..
Screencast from 25-02-25 13:39:13.webm

@coveralls
Copy link

coveralls commented Feb 25, 2025

Pull Request Test Coverage Report for Build 13521188938

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 92.414%

Totals Coverage Status
Change from base Build 13501369568: 0.003%
Covered Lines: 6773
Relevant Lines: 7329

💛 - Coveralls

@MarcelGeo
Copy link
Collaborator Author

The length requirement looks fine.

We also have reserved name validation. Not sure with the generic error but ok.. Screencast from 25-02-25 13:39:13.webm

Yeah, I updated it.

@MarcelGeo MarcelGeo merged commit df31432 into develop Feb 26, 2025
3 of 4 checks passed
@MarcelGeo MarcelGeo deleted the fix_username_validation branch February 26, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants