Skip to content

Don't allow SSO users update their profile#416

Merged
varmar05 merged 9 commits intodev-r19from
can_edit_profile
Apr 2, 2025
Merged

Don't allow SSO users update their profile#416
varmar05 merged 9 commits intodev-r19from
can_edit_profile

Conversation

@harminius
Copy link
Contributor

@harminius harminius commented Apr 1, 2025

Users that signed in with SSO are not allowed to change their email, name or password.

Frontend does not show the button to update the profile. 🪹

Backend blocks profile update ⛔

image

Unittest only for admin endpoint as I'm not able to login as SSO user (right now)

@harminius harminius requested review from MarcelGeo and varmar05 April 1, 2025 12:20
@coveralls
Copy link

coveralls commented Apr 1, 2025

Pull Request Test Coverage Report for Build 14213913227

Details

  • 31 of 31 (100.0%) changed or added relevant lines in 5 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 92.274%

Files with Coverage Reduction New Missed Lines %
server/mergin/auth/app.py 1 98.63%
server/mergin/auth/controller.py 13 91.93%
Totals Coverage Status
Change from base Build 14167313338: -0.04%
Covered Lines: 6891
Relevant Lines: 7468

💛 - Coveralls

@varmar05 varmar05 merged commit 49fca15 into dev-r19 Apr 2, 2025
4 checks passed
@MarcelGeo MarcelGeo deleted the can_edit_profile branch April 23, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants