Relocate CE deployment scripts. Introduce EE deployment scripts. #420#421
Merged
Relocate CE deployment scripts. Introduce EE deployment scripts. #420#421
Conversation
Closed
Pull Request Test Coverage Report for Build 14618682707Details
💛 - Coveralls |
MarcelGeo
requested changes
Apr 10, 2025
Collaborator
There was a problem hiding this comment.
Good job, just 💅
- grep readme in rest of repo (e.g. https://github.com/MerginMaps/server/blob/master/development.md#running-locally-in-a-docker-composition needs to be adjusted)
- move docker-compose.yml and others away from main folder (if not)
- grep documentation and find some links to these new files
- add some reasonable readme to deployment of community - add link to main README.md for this deployment section.
MarcelGeo
reviewed
Apr 11, 2025
varmar05
requested changes
Apr 11, 2025
Collaborator
|
I wonder if we do not have to many duplicates here, as a lot of stuff is the same for CE and EE deployment. Maybe we could introduce some 'common' folder? |
varmar05
reviewed
Apr 14, 2025
harminius
reviewed
Apr 22, 2025
harminius
reviewed
Apr 22, 2025
harminius
reviewed
Apr 22, 2025
harminius
reviewed
Apr 22, 2025
MarcelGeo
approved these changes
Apr 23, 2025
Collaborator
MarcelGeo
left a comment
There was a problem hiding this comment.
Just minor upgrade to readme. If @harminius finish tests, we can merge this 🎉
MarcelGeo
approved these changes
Apr 23, 2025
harminius
approved these changes
Apr 23, 2025
varmar05
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.