Initial version for zip download rework#426
Merged
Conversation
MarcelGeo
reviewed
Apr 17, 2025
Pull Request Test Coverage Report for Build 14704633098Details
💛 - Coveralls |
varmar05
commented
Apr 22, 2025
varmar05
commented
Apr 22, 2025
- timeut for downloadArchive - admin, project dashboard and project version download
varmar05
commented
Apr 25, 2025
- add test for 200 - increase max download size limit to 20GB - functions description - partial archive expiration in seconds
varmar05
commented
Apr 25, 2025
Collaborator
Author
|
Could you guys also double check we have disabled response buffers on proxy for this endpoint? |
Collaborator
I updated no buffer endpoint in nginx.conf. See 3f31b3f. There are 🏂 questions about that:
|
… download it in case of public project
Collaborator
|
@varmar05 introduced configurable buffering for x accel in download zip. |
MarcelGeo
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite download zip functionality so it creates a background task for zip construction first and only serves content when ready.
So far this is only prototype with some basic workflow
TODO:
rename endpoint (make it private)fix testsremove unused download functions and libraries, clean upfrontendupdate nginx config, make sure buffering settings are correct [:question: ]make sure, that cleanup of partial is ok - add to controller safe check if .partial is not update more than 30minutes.Dashboard
introducing polling for download zip file in following way:
sending HEAD request to the server until 200 is not returned, if 200 is returned -> download file
added loading indicator and disable dowloading

added maximum of 100 retries for download
🔨