Skip to content

use quote to encode filenames with special chars :japan #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcelGeo merged 1 commit into from
May 2, 2025
Merged

use quote to encode filenames with special chars :japan #446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/mergin/sync/private_api_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-MerginMaps-Commercial
import os
from datetime import datetime, timedelta, timezone
from urllib.parse import quote
from blinker import signal
from connexion import NoContent
from flask import (
Expand Down Expand Up @@ -347,8 +348,9 @@ def download_project(id: str, version=None): # noqa: E501 # pylint: disable=W06
else:
resp = send_file(project_version.zip_path, mimetype="application/zip")

file_name = quote(f"{project.name}-v{lookup_version}.zip".encode("utf-8"))
resp.headers["Content-Disposition"] = (
f"attachment; filename={project.name}-v{lookup_version}.zip"
f"attachment; filename*=UTF-8''{file_name}"
)
return resp

Expand Down
Loading