Skip to content

Breacrumbs fix + small app header enhancements#460

Merged
MarcelGeo merged 4 commits intodevelopfrom
gh#2907-breacrumps-fix
Jun 3, 2025
Merged

Breacrumbs fix + small app header enhancements#460
MarcelGeo merged 4 commits intodevelopfrom
gh#2907-breacrumps-fix

Conversation

@MarcelGeo
Copy link
Collaborator

@MarcelGeo MarcelGeo commented May 30, 2025

Fixed 🔨

  • app breadcrumbs component now accepts also function in meta, where are parsed route params
  • there was issue with beforeEnter handler, where meta was not provided properly
  • switching breadcrumbs in case of files or version details are showing

Screenshot from 2025-05-30 14-34-46

Enhancements:

  • add sign in button for public view of projects
  • get rid of console error in case of non logged user

@MarcelGeo MarcelGeo requested a review from harminius May 30, 2025 14:11
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15348621867

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.74%

Totals Coverage Status
Change from base Build 15270623553: 0.0%
Covered Lines: 7075
Relevant Lines: 7712

💛 - Coveralls

Copy link
Contributor

@harminius harminius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to run it locally.
I cannot make it working

Screencast.from.02-06-25.11.04.14.webm

@MarcelGeo
Copy link
Collaborator Author

I suggest to run it locally. I cannot make it working
Screencast.from.02-06-25.11.04.14.webm

Yeah, it was running localy by development. Try to yarn build:libs

@MarcelGeo MarcelGeo merged commit e4c1543 into develop Jun 3, 2025
4 checks passed
@MarcelGeo MarcelGeo deleted the gh#2907-breacrumps-fix branch June 3, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants