Skip to content

Adjust avatar font size globally#486

Merged
MarcelGeo merged 3 commits intodevelopfrom
avatar_font_size
Aug 13, 2025
Merged

Adjust avatar font size globally#486
MarcelGeo merged 3 commits intodevelopfrom
avatar_font_size

Conversation

@harminius
Copy link
Contributor

@harminius harminius commented Aug 4, 2025

Fixes https://github.com/MerginMaps/server-private/issues/3041

Adjust avatar font sizes to align with Figma design

image

propagates correctly to members page:

image

@harminius harminius requested a review from MarcelGeo August 4, 2025 14:49
@coveralls
Copy link

coveralls commented Aug 4, 2025

Pull Request Test Coverage Report for Build 16909663246

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 188 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-2.3%) to 91.925%

Files with Coverage Reduction New Missed Lines %
server/mergin/sync/utils.py 2 85.07%
server/mergin/app.py 4 78.6%
server/mergin/tests/test_middleware.py 5 84.44%
server/mergin/auth/commands.py 10 58.33%
server/mergin/sync/commands.py 56 31.76%
server/mergin/commands.py 111 22.6%
Totals Coverage Status
Change from base Build 16718186679: -2.3%
Covered Lines: 7126
Relevant Lines: 7752

💛 - Coveralls

.p-avatar {
background-color: $avatarBg;
border-radius: $borderRadius;
font-size: $avatarFontSize !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not rewrite these files.

Use _extenstions.scss to tweak .p-avatar class. With something like

.p-avatar:not(.p-avatar-lg):not(.p-avatar-xl) {
  font-size: 0.875rem;
}

We could then double chek if e.g. profile avatar is ok... as it's -lg

Some styles which are really defaults are comming from inline loader from primeuix library.

image

@harminius harminius requested a review from MarcelGeo August 12, 2025 13:03
Copy link
Collaborator

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are upgrading these _miscs.scss , add here comment that we are rewriting it to some other defaults. Double check private version.

@MarcelGeo MarcelGeo merged commit 6179b1f into develop Aug 13, 2025
4 checks passed
@MarcelGeo MarcelGeo deleted the avatar_font_size branch August 13, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants