Remove upload chunks only if push was successful#495
Merged
MarcelGeo merged 1 commit intodev-r84-concurrent-pushfrom Aug 15, 2025
Merged
Remove upload chunks only if push was successful#495MarcelGeo merged 1 commit intodev-r84-concurrent-pushfrom
MarcelGeo merged 1 commit intodev-r84-concurrent-pushfrom
Conversation
Pull Request Test Coverage Report for Build 16986284909Details
💛 - Coveralls |
MarcelGeo
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove uploaded chunks not after they were used but only if whole push transaction was successful.
Fix the issue if client (v2) wants to reuse uploaded chunks after some failure. It also solves the issue of one chunk being used for more than one file (kind of edge case of the same file with different names).