Skip to content

Remove upload chunks only if push was successful#495

Merged
MarcelGeo merged 1 commit intodev-r84-concurrent-pushfrom
fix_remove_chunks
Aug 15, 2025
Merged

Remove upload chunks only if push was successful#495
MarcelGeo merged 1 commit intodev-r84-concurrent-pushfrom
fix_remove_chunks

Conversation

@varmar05
Copy link
Collaborator

Remove uploaded chunks not after they were used but only if whole push transaction was successful.

Fix the issue if client (v2) wants to reuse uploaded chunks after some failure. It also solves the issue of one chunk being used for more than one file (kind of edge case of the same file with different names).

@varmar05 varmar05 requested a review from MarcelGeo August 15, 2025 08:34
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16986284909

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 91.894%

Files with Coverage Reduction New Missed Lines %
server/mergin/sync/models.py 1 97.02%
Totals Coverage Status
Change from base Build 16932482056: 0.02%
Covered Lines: 7471
Relevant Lines: 8130

💛 - Coveralls

@MarcelGeo MarcelGeo merged commit c5a1008 into dev-r84-concurrent-push Aug 15, 2025
4 checks passed
@MarcelGeo MarcelGeo deleted the fix_remove_chunks branch September 24, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants