Merged
Conversation
- head request cannot create new celery job - flask does not remove partial zip - celery care of cleaning up abandoned zip partials
varmar05
approved these changes
Aug 15, 2025
| assert resp.status_code == expected | ||
| assert mock_create_zip.called if expected == 202 else not mock_create_zip.called | ||
| if not version and expected != 200: | ||
| finally: |
Collaborator
There was a problem hiding this comment.
I think it is better to do test cleanups at the beginning
- you have results from failed tests
- you are sure to have a clean state for new test
Pull Request Test Coverage Report for Build 16990906892Details
💛 - Coveralls |
MarcelGeo
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/MerginMaps/server-private/issues/3061 https://github.com/MerginMaps/server-private/issues/3060