Return whole project nfo dump from project versions#506
Merged
MarcelGeo merged 1 commit intodev-r84-concurrent-pushfrom Sep 8, 2025
Merged
Return whole project nfo dump from project versions#506MarcelGeo merged 1 commit intodev-r84-concurrent-pushfrom
MarcelGeo merged 1 commit intodev-r84-concurrent-pushfrom
Conversation
MarcelGeo
changed the title
varmar05
reviewed
Sep 4, 2025
| ).dump(pv), | ||
| 201, | ||
| ) | ||
| return ProjectSchema().dump(project), 201 |
Collaborator
There was a problem hiding this comment.
we discussed this with @tomasMizera and it seems not all data is needed, e.g. history in files field.
Could you double check we return only what's needed? (Probably inline with new v2 project info)
Collaborator
Author
There was a problem hiding this comment.
ok we can do it in separated PR / ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO ensure that project info dump will be properly saved in clients .mergin folders, we are returning current project info created from version instead of project version.