Skip to content

Cache last sign in date in User table#509

Merged
MarcelGeo merged 1 commit intomasterfrom
cache_last_login
Sep 10, 2025
Merged

Cache last sign in date in User table#509
MarcelGeo merged 1 commit intomasterfrom
cache_last_login

Conversation

@varmar05
Copy link
Collaborator

@varmar05 varmar05 commented Sep 9, 2025

We want to have user's last successful sign in date available in User table so it is quickly accessible by APIs. We update the value at user login. Also there is a fallback option to calculate login dates from LoginHistory and cache the result.

In DB migration we only add new column and leave data to be updated on demand.

@varmar05 varmar05 requested a review from MarcelGeo September 9, 2025 13:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17584746203

Details

  • 20 of 21 (95.24%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 94.318%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/mergin/auth/models.py 11 12 91.67%
Totals Coverage Status
Change from base Build 17550000582: 0.002%
Covered Lines: 7553
Relevant Lines: 8008

💛 - Coveralls

@MarcelGeo MarcelGeo merged commit d2cc128 into master Sep 10, 2025
4 checks passed
@MarcelGeo MarcelGeo deleted the cache_last_login branch September 10, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants