MPC String Value From Key Attribute Fix#1963
Merged
AArnott merged 2 commits intoMessagePack-CSharp:masterfrom Sep 25, 2024
Merged
MPC String Value From Key Attribute Fix#1963AArnott merged 2 commits intoMessagePack-CSharp:masterfrom
AArnott merged 2 commits intoMessagePack-CSharp:masterfrom
Conversation
- when a string key is defined as a `Key`'s attribute, ensure that `mpc` generates the Span attributes based on the key defined and not the property name - add `StringKeyAttributeMapModeTest` in `GeneratedStringKeyFormatterTest.cs`
alimakki
force-pushed
the
mpc_string_value_from_key_attribute_fix
branch
from
80e9bab to
fdf76f7
Compare
AArnott
requested changes
Sep 25, 2024
Collaborator
AArnott
left a comment
AArnott
left a comment
There was a problem hiding this comment.
Thanks for submitting this. It looks almost ready.
…re indexing to `0`, otherwise default back to `item.Name`
This was referenced Dec 2, 2025
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key's attribute, ensure thatmpcgenerates the Span binary representation based on the key defined in the attribute and not the property nameStringKeyAttributeMapModeTestinGeneratedStringKeyFormatterTest.cs