GitHub extraction#122
Merged
Sam Clarke-Green (t00sa) merged 9 commits intoMetOffice:mainfrom Oct 30, 2025
Merged
Conversation
James Bruten (james-bruten-mo)
requested review from
Jenny Hickson (jennyhickson) and
Sam Clarke-Green (t00sa)
Collaborator
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
There was a problem hiding this comment.
Looks fine. I've suggested a couple of tweaks but it's up to you whether you think they're an improvement or not...
Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
James Bruten (james-bruten-mo)
requested a review
from Sam Clarke-Green (t00sa)
Collaborator
Author
|
Sorry, going to need a change to these files to allow access via tokens to support running on Monsoon. I'll put this back to in progress until that's done |
Collaborator
Author
|
Changes to allow running with https and tokens now added. Ready for review again Sam Clarke-Green (@t00sa) |
Sam Clarke-Green (t00sa)
approved these changes
Oct 30, 2025
Collaborator
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
There was a problem hiding this comment.
Looks sensible to me.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds files required for rose stem extraction from github, either syncing a local clone, or cloning from github or from a github mirror.
This also rearranges some of the file structure in this repo, creating a new
github_scriptsrepo in which the new files,suite_report_gitandgit_bdiffnow live. The files were moved in the first commit - any subsequent changes to existing files are in later commits (actually it looks like github displays those changes nicely anyway).The changes to suite_data make a modification to finding the clone source now that Cylc8.6 is available. I had expected this variable to be available in the cylc database, but it isn't exposed there, so instead it's reading a log message from the suite.
It also changes to use the clone and sync functions from the new get_git_sources file to reduce duplication a bit.