Skip to content

Conversation

@james-bruten-mo
Copy link
Collaborator

This PR slightly tidies the top level of the SimSys_Scripts repo, moving all (almost) scripts into their own directories.
The only remaining ones are the old suite_report and fcm_bdiff scripts which are left in their original place for now. I suggest we give it a release cycle or so and then delete these.

@james-bruten-mo james-bruten-mo self-assigned this Dec 2, 2025
@james-bruten-mo james-bruten-mo added this to the Git Migration milestone Dec 2, 2025
Copy link
Collaborator

@jennyhickson jennyhickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styling.py isn't part of lfric_styling - the comment at the top says its appying umdp3 styling to source code. It looks like a copy of https://github.com/MetOffice/um/blob/main/admin/code_styling/styling.py (which is called by apply_styling) but with the definitions at the top now coming from styling_keywords.py. Not even sure if styling.py has all its dependencies in here. Could it even get removed? Or is it used by the UMDP3 checker (thats when it was pulled in)

Generally feels like an area that could be condensed down so that lfric_styling.py isn't actually needed but just passes an input to a more general script. Also not sure how the UM's apply_styling stuff differs from the umdp3_fixer and if those could be combined too!

styling_keywords.py does get used by both styling and lfric_styling so it probably makes sense to keep them together if they're all staying, but maybe rethink the folder name?

Copy link
Collaborator

@jennyhickson jennyhickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jennyhickson jennyhickson merged commit fbd63bd into MetOffice:main Dec 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants