Merged
Conversation
James Bruten (james-bruten-mo)
requested review from
a team,
Cameron Bateman (cameronbateman-mo),
Erica Neininger (ericaneininger) and
R Sharp (r-sharp)
and removed request for
a team and
Erica Neininger (ericaneininger)
Cameron Bateman (cameronbateman-mo)
approved these changes
Dec 17, 2024
Contributor
Cameron Bateman (cameronbateman-mo)
left a comment
Cameron Bateman (cameronbateman-mo)
left a comment
There was a problem hiding this comment.
All looks good.
One comment on code formatting but doesn't effect functionality.
R Sharp (r-sharp)
approved these changes
Dec 17, 2024
Contributor
R Sharp (r-sharp)
left a comment
R Sharp (r-sharp)
left a comment
There was a problem hiding this comment.
I requested some tweaks to the PR text itself (in conversation with James). I would also re-iterate Cameron's comment, but Black is Black and we will be assimilated.
Otherwise the change looks good to me.
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One request from the reviewer meeting was to have a template docstring to describe what a macro is doing.
At the moment the script removes docstrings from the macros - this was done to aid development of the script, but it would be better practice to not remove them now.
This PR will remove the parsing of docstrings from the script.