UKCA test suite port to git#1
UKCA test suite port to git#1Erica Neininger (ericaneininger) merged 24 commits intoMetOffice:mainfrom james-bruten-mo:ukca_git_test
Conversation
|
Sorry if you've started looking, just done a minor further commit |
Pierre Siddall (Pierre-siddall)
left a comment
There was a problem hiding this comment.
This mostly looks good on my end of things and thank you for paying attention to use f-strings instead of .format() . Just a couple of really tiny suggestions from my end regarding raising slightly more informative errors, I think it would be good to raise these errors to help developer debug any issues they would get further on down the line.
rose-stem/lib/python/utils.py
Outdated
| def get_git_ref(working_copy_path): | ||
| proc = Popen(['git', '-C', working_copy_path, 'rev-parse', 'HEAD'], stdout=PIPE, text=True) | ||
| if proc.wait(): | ||
| raise Exception('Could not determine the HEAD commit.') |
There was a problem hiding this comment.
| raise Exception('Could not determine the HEAD commit.') | |
| raise RuntimeError('Could not determine the HEAD commit.') |
Similarly, here I'd raise a runtime error as the if statement verifies whether the process has finished.
|
Thanks Pierre. For the get_site function I'm not sure this is a value error, so I'm going to leave it as it is. |
Yeah that makes sense I though ValueError would be a stretch but I thought I'd jot it down in the review just in case. With this being said everything else looks good so I'm happy to approve this. |
Pierre Siddall (Pierre-siddall)
left a comment
There was a problem hiding this comment.
This looks good to go to me now :) .
|
Thanks Pierre, I missed an import of the deleted function, so just removed that |
Erica Neininger (ericaneininger)
left a comment
There was a problem hiding this comment.
All good. One minor typo-in-a-comment suggestion :)
Co-authored-by: Erica Neininger <107684099+ericaneininger@users.noreply.github.com>
Erica Neininger (ericaneininger)
left a comment
There was a problem hiding this comment.
Thanks, happy to approve.
312fdd5
into
MetOffice:main
This sets up the UKCA test suite to run using git sources. The primary changes are to the extraction of the code. This uses central scripts stored in SimSys_Scripts. This PR also removes the umdp3_checker which is also now centrally installed in SimSys_Scripts.
It's been tested at meto and on the VM. The meto trac.log is below:
Test Suite Results - ukca - ukca_git/run2
Suite Information
Task Information
✅ succeeded tasks - 2