NGLASS-1141 Make accordion PR to upstream neuroglancer#121
Open
Aiga115 wants to merge 3 commits intofeat/tab-accordionsfrom
Open
NGLASS-1141 Make accordion PR to upstream neuroglancer#121Aiga115 wants to merge 3 commits intofeat/tab-accordionsfrom
Aiga115 wants to merge 3 commits intofeat/tab-accordionsfrom
Conversation
seankmartin
reviewed
Mar 6, 2026
|
|
||
| const useAccordions = typeof NEUROGLANCER_USE_ACCORDIONS !== 'undefined' ? NEUROGLANCER_USE_ACCORDIONS : true; | ||
| if (!useAccordions) { | ||
| container.classList.add("no-border"); |
There was a problem hiding this comment.
this name would be better more specific, like neuroglancer-accordion-no-border
| NEUROGLANCER_BRAINMAPS_CLIENT_ID: JSON.stringify( | ||
| "639403125587-4k5hgdfumtrvur8v48e3pr7oo91d765k.apps.googleusercontent.com", | ||
| ), | ||
| NEUROGLANCER_USE_ACCORDIONS: process.env.NEUROGLANCER_USE_ACCORDIONS === 'true', |
There was a problem hiding this comment.
We can comment this out like the other examples in this file, but great to include as an example
| font-family: monospace; | ||
| font-size: medium; | ||
| flex: 1; | ||
| text-overflow: ellipsis; |
|
We also need to modify the tooltip on the chevron for expand collapse |
seankmartin
reviewed
Mar 6, 2026
| constructor( | ||
| public jsonKey: string, | ||
| private defaultExpanded = false, | ||
| private defaultExpanded = true, |
There was a problem hiding this comment.
with the inclusion of the ability to disable the accordions, I think we can set this back to false
if there is a section set to be non-expanded and then we disable accordions does it still show?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #NGLASS-1141
Problem: Make accordion PR to upstream neuroglancer
Solution:
Result:
view without annotation use:
