Merged
Conversation
gidili
approved these changes
Sep 27, 2018
Member
gidili
left a comment
gidili
left a comment
There was a problem hiding this comment.
Looking good to me 👍 thanks @rodriguez-facundo
Member
|
@NeZanyat can you also review? |
Contributor
|
Hi everyone, thanks for work on this script, it looks really nice, but I was planning to move all service things like this into one Makefile, it will be more unified. That's why I can't merge this PR right now, but I'll take some useful things from this PR and will put them into Makefile |
Author
|
sure, no problem @NeZanyat . Should I close this PR or you will? |
Contributor
|
Leave it as for now, I'll close it in future |
NeZanyat
approved these changes
Sep 27, 2018
Contributor
NeZanyat
left a comment
NeZanyat
left a comment
There was a problem hiding this comment.
Let's keep this instructions as for now, anyway it will be useful, till Makefile will be here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create script to install scidash
https://trello.com/c/9Jkl27NX/242-create-script-to-install-scidash
Changes
add script to install scidash
Related issues
this closes #48