This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Use async/await instead of then #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
reviewed
Aug 24, 2022
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Good idea! Had some suggestions.
Gudahtt
reviewed
Aug 25, 2022
Gudahtt
reviewed
Aug 25, 2022
| * Returns the currently initialized keyring that manages | ||
| * the specified `address` if one exists. | ||
| * | ||
| * @param {string} address - An account address. |
Member
There was a problem hiding this comment.
Nit: There is a .then a few lines up from here in getAccounts that we can remove as well
Gudahtt
reviewed
Aug 25, 2022
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
Merged
Gudahtt
added a commit
that referenced
this pull request
Nov 7, 2022
A new vault should be unlocked after being created, because the password is submitted as part of creating the vault. This was accidentally broken as part of #148. A unit test has been added to ensure this doesn't happen again.
Gudahtt
added a commit
that referenced
this pull request
Nov 7, 2022
A new vault should be unlocked after being created, because the password is submitted as part of creating the vault. This was accidentally broken as part of #148. A unit test has been added to ensure this doesn't happen again.
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much easier to read than the mess of
then's.