This repository was archived by the owner on Oct 7, 2024. It is now read-only.
11.0.0 #225
Merged
11.0.0 #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
mcmire
reviewed
May 12, 2023
CHANGELOG.md
Outdated
Comment on lines
12
to
15
| - docs: Update README ([#209](https://github.com/MetaMask/KeyringController/pull/209)) | ||
| - deps: Unpin and bump @metamask/eth-sig-utils@5.0.2->^5.1.0 ([#224](https://github.com/MetaMask/KeyringController/pull/224)) |
Contributor
There was a problem hiding this comment.
Do we want to remove these last two entries since they aren't user-facing?
Member
There was a problem hiding this comment.
This entry is; this lets users of this package use later versions of eth-sig-util. Agreed on the readme update though
Gudahtt
reviewed
May 12, 2023
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Member
|
Had to reject the deployment, the code was missing! The GitHub actions workflows weren't updated after the TypeScript migration to include a build before publish. We should revert this, then try again after fixing the workflow |
Merged
Gudahtt
added a commit
that referenced
this pull request
May 12, 2023
Member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 11.0.0.