This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Allow non-object keyring serialized state #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
fix-qr-keyring-compatibility
branch
from
9ebdc0f to
836b5a4
Compare
The `addNewKeyring` method has been updated to support non-object keyring serialized state, which had been supported already on versions prior to v11. This allows us to remove a special-case for the simple keyring, which requires a JSON array as its serialized keyring state. When constructing a simple keyring, the method `addNewKeying` now expects the second parameter (`opts`) to be an array of private keys rather than an object with a `privateKeys` property. This is how it worked prior to v11.
Gudahtt
force-pushed
the
simplify-add-keyring-method
branch
from
cf828cd to
a1f4ca1
Compare
legobeat
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
addNewKeyringmethod has been updated to support non-object keyring serialized state, which had been supported already on versions prior to v11.This allows us to remove a special-case for the simple keyring, which requires a JSON array as its serialized keyring state.
When constructing a simple keyring, the method
addNewKeyingnow expects the second parameter (opts) to be an array of private keys rather than an object with aprivateKeysproperty. This is how it worked prior to v11.Changes
addNewKeying, the second parameter (opts) is now expected to be an array of private keys rather than an object with aprivateKeyspropertyReferences
None
Checklist