This repository was archived by the owner on Oct 7, 2024. It is now read-only.
Update browser-passworder to ^4.3.0
#310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Gudahtt
previously approved these changes
Nov 28, 2023
Member
Gudahtt
left a comment
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! Though we should mention the performance improvement in the changelog as well, not just the API change
mikesposito
dismissed
Gudahtt’s stale review
The merge-base changed after approval.
mikesposito
force-pushed
the
refactor/update-browser-passworder
branch
from
967105c to
f962ad4
Compare
Gudahtt
approved these changes
Nov 29, 2023
mikesposito
added a commit
that referenced
this pull request
Nov 29, 2023
* chore: update browser-passworder * refactor: remove `updateVault` from `GenericEncryptor`
legobeat
added a commit
that referenced
this pull request
Nov 30, 2023
legobeat
added a commit
that referenced
this pull request
Nov 30, 2023
Gudahtt
added a commit
that referenced
this pull request
Jan 9, 2024
* [15.x] Backport encryption improvements (#312) * Prefer cached `encryptionKey` for encryption when possible (#307) * fix: prefer encryptionKey for encryption when possible * refactor: add test case * Use encryptor `isVaultUpdated` (#310) * chore: update browser-passworder * refactor: remove `updateVault` from `GenericEncryptor` * 15.1.0 (#313) * 15.1.0 * edit changelog entries * rephrase changelog entry --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Michele Esposito <michele@esposito.codes> --------- Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Michele Esposito <michele@esposito.codes> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
@metamask/browser-passworderminimum version to 4.3.0The library
4.3.0version also providesisVaultUpdated, which gives us a chance to make the wayEthKeyringControllerchecks for a potential encryption upgrade more efficient.Changes
isVaultUpdatedproperty toGenericEncryptortype@metamask/browser-passworderto^4.3.0isVaultUpdatedmethod, the latter is used to check if the vault is updated instead ofupdateVaultGenericEncryptor'supdateVaultproperty has been removed as no longer usedReferences
Checklist