Skip to content
This repository was archived by the owner on Oct 7, 2024. It is now read-only.

Conversation

@mikesposito
Copy link
Member

@mikesposito mikesposito commented Jan 22, 2024

Description

Bump @metamask/keyring-api dep to ^3.0.0

Changes

  • CHANGED: Bump @metamask/keyring-api dep to ^3.0.0

References

Unblocks MetaMask/core#3779

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@mikesposito mikesposito requested a review from a team as a code owner January 22, 2024 10:45
@socket-security
Copy link

socket-security bot commented Jan 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/keyring-api@3.0.0 Transitive: environment, network +52 8.52 MB brad.decker, danfinlay, gudahtt, ...9 more

🚮 Removed packages: npm/@endo/env-options@1.1.0, npm/@metamask/approval-controller@5.1.1, npm/@metamask/base-controller@4.1.0, npm/@metamask/controller-utils@8.0.1, npm/@metamask/eth-query@4.0.0, npm/@metamask/keyring-api@2.0.0, npm/@metamask/permission-controller@7.1.0, npm/@metamask/phishing-controller@8.0.1, npm/@metamask/post-message-stream@7.0.0, npm/@metamask/snaps-controllers@3.6.0, npm/@metamask/snaps-registry@3.0.0, npm/@metamask/snaps-rpc-methods@4.1.0, npm/@metamask/snaps-utils@5.2.0, npm/@noble/curves@1.3.0, npm/@spruceid/siwe-parser@1.1.3, npm/@types/bn.js@5.1.5, npm/@types/deep-freeze-strict@1.1.2, npm/@types/pbkdf2@3.1.2, npm/@types/punycode@2.1.3, npm/@types/secp256k1@4.0.6, npm/@xstate/fsm@2.1.0, npm/apg-js@4.3.0, npm/b4a@1.6.4, npm/base-x@3.0.9, npm/blakejs@1.2.1, npm/bn.js@5.2.1, npm/brorand@1.1.0, npm/browserify-aes@1.2.0, npm/browserify-zlib@0.2.0, npm/bs58@4.0.1, npm/bs58check@2.1.2, npm/buffer-xor@1.0.3, npm/cipher-base@1.0.4, npm/concat-stream@2.0.0, npm/core-util-is@1.0.3, npm/create-hash@1.2.0, npm/create-hmac@1.1.7, npm/cron-parser@4.9.0, npm/deep-freeze-strict@1.1.1, npm/duplexify@3.7.1, npm/elliptic@6.5.4, npm/eth-ens-namehash@2.0.8, npm/eth-phishing-detect@1.2.0, npm/ethereumjs-util@7.1.5, npm/ethjs-unit@0.1.6, npm/evp_bytestokey@1.0.3, npm/fast-fifo@1.3.2, npm/get-npm-tarball-url@2.1.0, npm/gunzip-maybe@1.4.2, npm/hash-base@3.1.0, npm/hash.js@1.1.7, npm/hmac-drbg@1.0.1, npm/idna-uts46-hx@2.3.1, npm/immer@9.0.21, npm/is-deflate@1.0.0, npm/is-gzip@1.0.0, npm/is-hex-prefixed@1.0.0, npm/js-sha3@0.5.7, npm/json-rpc-random-id@1.0.1, npm/keccak@3.0.4, npm/luxon@3.4.4, npm/md5.js@1.3.5, npm/minimalistic-assert@1.0.1, npm/minimalistic-crypto-utils@1.0.1, npm/node-addon-api@2.0.2, npm/node-gyp-build@4.8.0, npm/number-to-bn@1.7.0, npm/pbkdf2@3.1.2, npm/peek-stream@1.1.3, npm/process-nextick-args@2.0.1, npm/pumpify@1.5.1, npm/queue-tick@1.0.1, npm/readable-web-to-node-stream@3.0.2, npm/rfdc@1.3.1, npm/ripemd160@2.0.2, npm/rlp@2.2.7, npm/scrypt-js@3.0.1, npm/secp256k1@4.0.3, npm/ses@1.1.0, npm/setimmediate@1.0.5, npm/sha.js@2.4.11, npm/stream-shift@1.0.3, npm/streamx@2.15.6, npm/strip-hex-prefix@1.0.0, npm/tar-stream@3.1.7, npm/through2@2.0.5, npm/typedarray@0.0.6, npm/validate-npm-package-name@5.0.0, npm/xtend@4.0.2

View full report↗︎

@socket-security
Copy link

socket-security bot commented Jan 22, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/keyring-api@3.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@mikesposito
Copy link
Member Author

@SocketSecurity ignore npm/@metamask/keyring-api@3.0.0

@metamask/keyring-api@3.0.0 is the latest release

@mikesposito mikesposito merged commit fd8e05e into main Jan 22, 2024
@mikesposito mikesposito deleted the chore/update-keyring-api branch January 22, 2024 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants