fix(ci): fix release missing configuration #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
k-g-j
approved these changes
Sep 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
## Description This is the release candidate for version 1.0.0. See the changelogs for more details. The initial attempt failed, and thus the release was not properly finalized (no tags, no packages being published either), see: - e3522a2 - https://github.com/MetaMask/accounts/actions/runs/10905969009/job/30266281001 There was a missing configuration file, see: - #36 This will re-trigger the CI and should finalize the release 1.0.0.
ccharly
added a commit
that referenced
this pull request
Sep 18, 2024
## Description This configuration was missing. ## Fixes There is 2 strategies that can be handled by `MetaMask/action-publish-release` action: - `fixed`: Meaning all packages sharing the same version than the "global" version get released together * This was the strategy being used for: - e3522a2 - https://github.com/MetaMask/accounts/actions/runs/10905969009/job/30266281001 - `independent`: Meaning each packages got published with their own versions in a "independent" way * This is the strategy that we need for this monorepo
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
## Description This is the release candidate for version . See the changelogs for more details. ## Related PRs There was 2 attempts to create this release already: 1. #31 - There was a missing configuration file for one of the action which has been fixed by: * #36 2. #37 - This was an empty PR with the right title (which is a requirement for the release workflow) - However, one of the action to detect if this PR was a release did not go through, since the `package.json` was already set to `1.0.0`, see: * https://github.com/MetaMask/accounts/actions/runs/10907728925/job/30272211482 # Git The 2 previous PRs have been removed from the history to avoid having multiple `release: 1.0.0` commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This configuration was missing.
Fixes
There is 2 strategies that can be handled by
MetaMask/action-publish-releaseaction:fixed: Meaning all packages sharing the same version than the "global" version get released togetherindependent: Meaning each packages got published with their own versions in a "independent" way