feat: add LedgerKeyringV2 wrapper
#416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccharly
reviewed
Jan 5, 2026
ccharly
reviewed
Jan 7, 2026
ccharly
reviewed
Jan 7, 2026
mathieuartu
force-pushed
the
feat/ledger-keyring-v2
branch
from
3612df6 to
5b64db0
Compare
ccharly
reviewed
Jan 8, 2026
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
ccharly
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://consensyssoftware.atlassian.net/browse/MUL-1322
Examples
Note
Introduces a V2 wrapper for the Ledger keyring and wires it into the package.
LedgerKeyringV2(extendsEthKeyringWrapper) implementingKeyringV2; adapts legacyLedgerKeyringto unifiedKeyringAccountwith EOA scopes/methodsbip44:derive-indexandbip44:derive-path(incl. Ledger Live paths), plus account lookup, serialization, and deletionledger-keyring-v2fromindex.tsand documents inCHANGELOG.mdledger-keyring-v2.test.tscovering derivation parsing, caching, error cases, and path variants@metamask/keyring-apiand@metamask/account-api, adjusts Jest coverage thresholds, and updates README dependency graphWritten by Cursor Bugbot for commit a608974. This will update automatically on new commits. Configure here.