Skip to content

Conversation

@gusiri
Copy link
Contributor

@gusiri gusiri commented Mar 8, 2023

@gusiri gusiri requested review from a team and MRabenda as code owners March 8, 2023 18:48
@gusiri
Copy link
Contributor Author

gusiri commented Mar 8, 2023

Hi MetaMask team,
We did our best to reduce the logo size to less than 5KB, but this is the smallest size we could achieve.
Please let us know if the logo should be smaller. Thank you.

@MRabenda
Copy link
Collaborator

MRabenda commented Mar 9, 2023

@gusiri - thanks for the contribution, seems that your logo is pretty complex, and would be difficult to make it 5<kb but is still over 110kb which is a lot. If you made your best then let's leave. But I would like to double-check https://github.com/MetaMask/contract-metadata/blob/ba1af55e83fb4415c418ab7e789655d5479d83f3/images/SHOPX.svg do you want to have these paddings where logo is smaller than view box? If not can you remove them?

@gusiri
Copy link
Contributor Author

gusiri commented Mar 16, 2023

@MRabenda Hi MRabenda, thank you for the feedback
We tried to remove the paddings but failed. Can we use this version with the paddings please?

@MRabenda MRabenda merged commit 96ba011 into MetaMask:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants