Skip to content

NetworkController: Remove setActive option from upsertNetworkConfiguration #1259

@mcmire

Description

@mcmire

There are too many methods that can be used to switch networks, and as a result we have a LOT of tests for NetworkController. It is not difficult for consumers to call setActiveNetwork after calling upsertNetworkConfiguration if they wish to switch to a newly added or updated network. Therefore to minimize the test suite, we should remove this option from upsertNetworkConfiguration.

Metadata

Metadata

Assignees

No one assigned

    Labels

    team-wallet-frameworkDeprecated: Please use `team-core-platform` instead.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions