-
-
Notifications
You must be signed in to change notification settings - Fork 268
Closed
Labels
team-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.
Description
Historically, the providerConfig property in NetworkController has been used to switch and track the currently selected network as well as provide access to information about that network. That is now achieved with a combination of the selectedNetworkClientId and networkConfigurations properties as well as the configuration property on the NetworkClient interface. This means that we no longer need providerConfig and we can remove this redundant state.
Removing providerConfig is one thing, but there are also a ton of packages which make use of this property to access the currently selected chain, and we would want to make use of selectedNetworkClientId in combination with the NetworkController:getNetworkClientById action to do this instead.
Acceptance Criteria
-
providerConfigis removed from NetworkController (replaced withselectedNetworkClientIdand/or `networkConfigurations); NetworkController tests pass - [assets-controllers]
AccountTrackerControlleris updated to follow suit and tests pass - [assets-controllers]
AssetsContractControlleris updated to follow suit and tests pass - [assets-controllers]
NftControlleris updated to follow suit and tests pass - [assets-controllers]
NftDetectionControlleris updated to follow suit and tests pass - [assets-controllers]
TokensControlleris updated to follow suit and tests pass - [assets-controllers]
TokenListControlleris updated to follow suit and tests pass - [assets-controllers]
TokenRatesControlleris updated to follow suit and tests pass -
EnsControlleris updated to follow suit and tests pass -
GasFeeControlleris updated to follow suit and tests pass -
SelectedNetworkControllertests are updated to follow suit and tests pass -
TransactionControlleris updated to follow suit and tests pass
Metadata
Metadata
Assignees
Labels
team-wallet-frameworkDeprecated: Please use `team-core-platform` instead.Deprecated: Please use `team-core-platform` instead.