Make initializeProvider async
#1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
commented
Apr 13, 2023
The `initializeProvider` method has been made async. This method already triggered various async operations, but they were not being `await`-ed. Now they are, making this method easier to use and easier to test. This relates to MetaMask/metamask-extension#18587
Gudahtt
force-pushed
the
make-initialize-provider-async
branch
from
4e54636 to
c8006ef
Compare
mcmire
approved these changes
Apr 14, 2023
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Make `initializeProvider` async The `initializeProvider` method has been made async. This method already triggered various async operations, but they were not being `await`-ed. Now they are, making this method easier to use and easier to test. This relates to MetaMask/metamask-extension#18587 * Simply reset connection proxy test
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Make `initializeProvider` async The `initializeProvider` method has been made async. This method already triggered various async operations, but they were not being `await`-ed. Now they are, making this method easier to use and easier to test. This relates to MetaMask/metamask-extension#18587 * Simply reset connection proxy test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
initializeProvidermethod has been made async. This method already triggered various async operations, but they were not beingawait-ed. Now they are, making this method easier to use and easier to test.Changes
initializeProvidermethod is nowasyncReferences
This relates to MetaMask/metamask-extension#18587
Checklist