Make refreshNetwork async
#1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal method `refreshNetwork` has been made async. The method already called an asynchronous method internally, but it was not `await`-ed. Now it is. This method is only being called from within synchronous functions. They will be made async in later PRs. Because the async call was the last operation, this change effectively has no functional impact. This relates to #1176
mcmire
approved these changes
Apr 14, 2023
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The internal method `refreshNetwork` has been made async. The method already called an asynchronous method internally, but it was not `await`-ed. Now it is. This method is only being called from within synchronous functions. They will be made async in later PRs. Because the async call was the last operation, this change effectively has no functional impact. This relates to #1176
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The internal method `refreshNetwork` has been made async. The method already called an asynchronous method internally, but it was not `await`-ed. Now it is. This method is only being called from within synchronous functions. They will be made async in later PRs. Because the async call was the last operation, this change effectively has no functional impact. This relates to #1176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The internal method
refreshNetworkhas been made async. The method already called an asynchronous method internally, but it was notawait-ed. Now it is.This method is only being called from within synchronous functions. They will be made async in later PRs.
Because the async call was the last operation, this change effectively has no functional impact.
Changes
N/A
References
This relates to #1176
Checklist