Make network controller internal fields private #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
make-internal-network-controller-fields-private
branch
from
d9a3bd7 to
a0cfdb4
Compare
Member
Author
|
Rebased to resolve conflicts |
This comment was marked as resolved.
This comment was marked as resolved.
Internal network controller methods and fields are now private fields, using the JavaScript `#` syntax rather than the `private` TypeScript keyword. Closes #1177
Gudahtt
force-pushed
the
make-internal-network-controller-fields-private
branch
from
a0cfdb4 to
38330e4
Compare
mcmire
approved these changes
Apr 17, 2023
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Internal network controller methods and fields are now private fields, using the JavaScript `#` syntax rather than the `private` TypeScript keyword. Closes #1177
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Internal network controller methods and fields are now private fields, using the JavaScript `#` syntax rather than the `private` TypeScript keyword. Closes #1177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Internal network controller methods and fields are now private fields, using the JavaScript
#syntax rather than theprivateTypeScript keyword.Changes
privateTypeScript keywordReferences
Closes #1177
Checklist