Skip to content

Make setActiveNetwork async #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gudahtt merged 2 commits into from
Apr 14, 2023
Merged

Make setActiveNetwork async #1190

Gudahtt merged 2 commits into from
Apr 14, 2023

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 14, 2023

Description

The network controller method setActiveNetwork is now async. It will not resolve until the network switch has completed.

Changes

  • BREAKING: setActiveNetwork is now async

References

This relates to #1176

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Gudahtt
Make setActiveNetwork async
f77cc96 
The network controller method `setActiveNetwork` is now async. It will
not resolve until the network switch has completed.

This relates to #1176
@Gudahtt Gudahtt marked this pull request as ready for review April 14, 2023 19:27
@Gudahtt Gudahtt requested a review from a team as a code owner April 14, 2023 19:27
@Gudahtt Gudahtt mentioned this pull request Apr 14, 2023
Merged
3 tasks
mcmire
mcmire approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 269f4af into main Apr 14, 2023
@Gudahtt Gudahtt deleted the make-set-active-network-async branch April 14, 2023 21:54
@legobeat legobeat mentioned this pull request Apr 25, 2023
Merged
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Make setActiveNetwork async (#1190)
df8028e 
The network controller method `setActiveNetwork` is now async. It will
not resolve until the network switch has completed.

This relates to #1176
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Make setActiveNetwork async (#1190)
4d31b76 
The network controller method `setActiveNetwork` is now async. It will
not resolve until the network switch has completed.

This relates to #1176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmire mcmire mcmire approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gudahtt @mcmire