Restrict certain permissions by subject type #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
requested changes
Apr 20, 2023
Mrtenz
previously approved these changes
Apr 20, 2023
GuillaumeRx
reviewed
Apr 20, 2023
GuillaumeRx
previously approved these changes
Apr 20, 2023
Gudahtt
reviewed
Apr 20, 2023
Member
|
Looks great! Good catch. I can approve after we get CI passing |
FrederikBolding
dismissed stale reviews from GuillaumeRx and Mrtenz
via
4eda1ec
FrederikBolding
force-pushed
the
fb/restrict-certain-permissions-by-type
branch
from
4eda1ec to
db6d1c6
Compare
Gudahtt
approved these changes
Apr 20, 2023
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Restrict certain permissions by subject type * Move logic to validation function * Add tests * Address a PR comment * Expanded comment * Address PR comments * Fix import * Fix lint
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Restrict certain permissions by subject type * Move logic to validation function * Add tests * Address a PR comment * Expanded comment * Address PR comments * Fix import * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
subjectTypesfield to permission specifications, allowing certain permissions to be limited to access from certain subject types.If a request for permissions is made from a non-matching subject type we throw a method or endowment not found error.
Changes
subjectTypesfield to permission specificationsChecklist