Make resetConnection async
#1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
make-rollback-to-previous-provider-async
branch
from
0415411 to
948e8ae
Compare
Gudahtt
force-pushed
the
make-reset-connection-async
branch
from
a047b9e to
95f7ea9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
make-rollback-to-previous-provider-async
branch
from
948e8ae to
7f401cd
Compare
Gudahtt
force-pushed
the
make-reset-connection-async
branch
from
95f7ea9 to
c8fd207
Compare
Gudahtt
changed the base branch from
make-rollback-to-previous-provider-async
to
update-eip-1559-compatibility-during-network-lookup
Gudahtt
force-pushed
the
update-eip-1559-compatibility-during-network-lookup
branch
from
eb4fae4 to
4e1f13c
Compare
Gudahtt
force-pushed
the
make-reset-connection-async
branch
from
c8fd207 to
70f27b1
Compare
Base automatically changed from
update-eip-1559-compatibility-during-network-lookup
to
main
April 21, 2023 13:27
The network controller method `resetConnection` has been made async. It will not resolve until after the network has been fully reset. Relates to #1176
Gudahtt
force-pushed
the
make-reset-connection-async
branch
from
70f27b1 to
7c0f70f
Compare
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The network controller method
resetConnectionhas been made async. It will not resolve until after the network has been fully reset.Changes
resetConnectionis now asyncReferences
Relates to #1176
Checklist